QDB-16714 - Dask integration into Python API #98
Conversation
|
|
||
| @pytest.fixture | ||
| def gen_index(start_date, row_count): | ||
| def gen_index(start_date, row_count, frequency): |
There was a problem hiding this comment.
Where is gen_index invoked? Would it not require a default value for this parameter? Did you check the tests pass?
There was a problem hiding this comment.
its a leftover from test_dask.py
above this line i defined frequency fixture
from it you can change value passed to gen_index if needed
default behawior is the same as before, all tests pass
its not useful right, can be removed
There was a problem hiding this comment.
for test_dask.py i needed to have data split between multiple shards
defining additional fixture provides way to override behavior for selected tests only
There was a problem hiding this comment.
Oh, I get it, it's a fixture and we have a separate frequency fixture as well which is automatically injected.
Please keep conftest.py as in-sync as possible with the one in our dask repository.
There was a problem hiding this comment.
ok, i will update conftest in qdb-dask-integration to match
| return py::cast(qdb::numpy_query(_handle, query)); | ||
| } | ||
|
|
||
| py::object split_query_range(std::chrono::system_clock::time_point start, std::chrono::system_clock::time_point end, std::chrono::milliseconds delta) |
There was a problem hiding this comment.
Yeah this is not too useful right now, I assume you do the regex part in the dask connector now, which is probably not ideal.
Let's keep it as-is though.
Story details: https://app.shortcut.com/quasardb/story/16714